Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed FAQ Page UI #538

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Completed FAQ Page UI #538

merged 4 commits into from
Jul 25, 2023

Conversation

kaur-rajdeep
Copy link
Contributor

Related Issue

  • Information about the related issue

Closes: #491

Describe the changes you've made

Changed UI of the FAQ and renamed the images

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

image

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
product-3-d ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 3:36pm

@vercel
Copy link

vercel bot commented Jul 25, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @amanjaiman1 on Vercel.

@amanjaiman1 first needs to authorize it.

@amanjaiman1
Copy link
Owner

Good work @kaur-rajdeep ❤️

amanjaiman1
amanjaiman1 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Owner

@amanjaiman1 amanjaiman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feat: FAQ Page Modelised with new UI

@amanjaiman1 amanjaiman1 merged commit 4c8ac4f into amanjaiman1:main Jul 25, 2023
3 checks passed
@amanjaiman1 amanjaiman1 added gssoc23 This is for gssoc contributors 🟧 priority: high This is for high priority & Time Interval - 3 Days max 👨🏻‍🚒 goal: major leading to major changes in files/dependencies level3 Refactoring / Adding functionalities and removed 🟧 priority: high This is for high priority & Time Interval - 3 Days max labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjaiman1 amanjaiman1 amanjaiman1 approved these changes

Assignees
No one assigned
Labels
👨🏻‍🚒 goal: major leading to major changes in files/dependencies gssoc23 This is for gssoc contributors level3 Refactoring / Adding functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving the FAQ page UI
2 participants
@kaur-rajdeep @amanjaiman1